It depends on what types of videos you plan to do. If they're gameplay-focused videos in which what you're discussing is the gameplay itself and the exact situations you're encountering in that gameplay OR you're specifically trying to capture reactions to gameplay, then I would say to record while you're playing.
If, on the other hand, you're planning on doing a commentary other than something that is directly related to that moment in the game, it may be better to record vocals at a later time as it may detract from your attention while playing.
It all boils down to what style of video you want to go for - something more candid and reaction based or something potentially more thoughtful and planned out.